Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename registerPressurePlate to registerWeightedPressurePlate #3608

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

Benonardo
Copy link
Contributor

@Benonardo Benonardo commented Jul 20, 2023

This method in BlockStateModelGenerator uses the POWERED property, which is not present in PressurePlateBlock, only WeightedPressurePlateBlock.
Normal pressure plates are instead handled by BlockTexturePool#pressurePlate.
A case of confusion caused by the previous name can be seen here.

@Juuxel Juuxel added bug Fixes or discusses a bug within the mappings release A PR that targets a release version of Minecraft labels Jul 20, 2023
@Juuxel Juuxel requested a review from a team July 20, 2023 17:54
@Benonardo Benonardo closed this Jul 20, 2023
@Benonardo Benonardo reopened this Jul 20, 2023
@Benonardo Benonardo changed the title Rename createPressurePlateBlockState to createWeightedPressurePlateBl… Rename registerPressurePlate to registerWeightedPressurePlate Jul 20, 2023
@Juuxel Juuxel merged commit 9672e1f into FabricMC:1.20.1 Jul 20, 2023
3 checks passed
@Benonardo Benonardo deleted the datagen-pressure-plate branch July 21, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes or discusses a bug within the mappings release A PR that targets a release version of Minecraft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants